Messages in this thread | | | Date | Fri, 23 Jun 2023 14:30:11 +0100 | From | Jonathan Cameron <> | Subject | Re: [PATCH v7 27/27] cxl/core/regs: Rename phys_addr in cxl_map_component_regs() |
| |
On Thu, 22 Jun 2023 15:55:23 -0500 Terry Bowman <terry.bowman@amd.com> wrote:
> From: Robert Richter <rrichter@amd.com> > > Trivial change that renames variable phys_addr in > cxl_map_component_regs() to shorten its length to keep the 80 char > size limit for the line and also for consistency between the different > paths. > > Signed-off-by: Robert Richter <rrichter@amd.com> > Signed-off-by: Terry Bowman <terry.bowman@amd.com>
Fair enough on consistency side. I don't care about being just over 80 chars :)
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > drivers/cxl/core/regs.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/cxl/core/regs.c b/drivers/cxl/core/regs.c > index 982ef79670c7..ba351a887040 100644 > --- a/drivers/cxl/core/regs.c > +++ b/drivers/cxl/core/regs.c > @@ -216,16 +216,16 @@ int cxl_map_component_regs(struct cxl_register_map *map, > > for (i = 0; i < ARRAY_SIZE(mapinfo); i++) { > struct mapinfo *mi = &mapinfo[i]; > - resource_size_t phys_addr; > + resource_size_t addr; > resource_size_t length; > > if (!mi->rmap->valid) > continue; > if (!test_bit(mi->rmap->id, &map_mask)) > continue; > - phys_addr = map->resource + mi->rmap->offset; > + addr = map->resource + mi->rmap->offset; > length = mi->rmap->size; > - *(mi->addr) = devm_cxl_iomap_block(dev, phys_addr, length); > + *(mi->addr) = devm_cxl_iomap_block(dev, addr, length); > if (!*(mi->addr)) > return -ENOMEM; > }
| |