Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | Fei Shao <> | Subject | [PATCH v2] clk: Fix memory leak in devm_clk_notifier_register() | Date | Mon, 19 Jun 2023 11:22:53 +0800 |
| |
devm_clk_notifier_register() allocates a devres resource for clk notifier but didn't register that to the device, so the notifier didn't get unregistered on device detach and the allocated resource was leaked.
Fix the issue by registering the resource through devres_add().
Fixes: 6d30d50d037d ("clk: add devm variant of clk_notifier_register") Signed-off-by: Fei Shao <fshao@chromium.org> ---
Changes in v2: - Revise commit message
drivers/clk/clk.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 7ac9f7a8cb84..c249f9791ae8 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -4741,6 +4741,7 @@ int devm_clk_notifier_register(struct device *dev, struct clk *clk, if (!ret) { devres->clk = clk; devres->nb = nb; + devres_add(dev, devres); } else { devres_free(devres); } -- 2.41.0.162.gfafddb0af9-goog
| ![\](/images/icornerr.gif) |