Messages in this thread | | | From | andy.shevchenko@gmail ... | Date | Mon, 29 May 2023 08:26:48 +0300 | Subject | Re: [PATCH v4 7/7] iio: light: vcnl4000: Add calibration bias for 4040/4200 |
| |
Mon, May 22, 2023 at 04:26:21PM +0200, Astrid Rost kirjoitti: > The calibration bias is setting the LED current to change > the detection distance. > Add read/write attribute for proximity calibration bias and read > attribute for available values. > This is supported for vcnl4040 and vcnl4200.
Indentation of the commit message is rather random.
...
> +
This means that one of the previous change missed the blank line here.
> +static const int vcnl4040_ps_calibbias_ua[][2] = { > + {0, 50000}, > + {0, 75000}, > + {0, 100000}, > + {0, 120000}, > + {0, 140000}, > + {0, 160000}, > + {0, 180000}, > + {0, 200000}, > +}; > + > static const int vcnl4040_als_persistence[] = {1, 2, 4, 8}; > static const int vcnl4040_ps_persistence[] = {1, 2, 3, 4}; > static const int vcnl4040_ps_oversampling_ratio[] = {1, 2, 4, 8};
> return ret; > }
...
> +static ssize_t vcnl4040_read_ps_calibbias(struct vcnl4000_data *data, int *val, int *val2) > +{ > + int ret; > + > + ret = i2c_smbus_read_word_data(data->client, VCNL4200_PS_CONF3); > + if (ret < 0) > + return ret; > + > + ret = FIELD_GET(VCNL4040_PS_MS_LED_I, ret); > + > + if (ret >= ARRAY_SIZE(vcnl4040_ps_calibbias_ua)) > + return -EINVAL; > + > + *val = vcnl4040_ps_calibbias_ua[ret][0]; > + *val2 = vcnl4040_ps_calibbias_ua[ret][1];
> + return ret;
Are you sure this is correct?
> +}
...
> +static ssize_t vcnl4040_write_ps_calibbias(struct vcnl4000_data *data, int val) > +{ > + unsigned int i; > + int ret, index = -1;
i or index is redundant.
> + u16 regval; > + > + for (i = 0; i < ARRAY_SIZE(vcnl4040_ps_calibbias_ua); i++) { > + if (val == vcnl4040_ps_calibbias_ua[i][1]) { > + index = i; > + break; > + } > + } > + > + if (index < 0) > + return -EINVAL; > + > + mutex_lock(&data->vcnl4000_lock); > + > + ret = i2c_smbus_read_word_data(data->client, VCNL4200_PS_CONF3); > + if (ret < 0) > + goto out; > + > + regval = (ret & ~VCNL4040_PS_MS_LED_I) | > + FIELD_PREP(VCNL4040_PS_MS_LED_I, index); > + ret = i2c_smbus_write_word_data(data->client, VCNL4200_PS_CONF3, > + regval); > + > +out:
out_unlock:
> + mutex_unlock(&data->vcnl4000_lock); > + return ret; > +}
...
> default: > return -EINVAL; > } > -
Stray and ping-pong style of change at the same time.
Avoid ping-pong style when you add something in the series which is being removed aftewards in the same series without need to be added in the first place.
> + case IIO_CHAN_INFO_CALIBBIAS: > + switch (chan->type) { > + case IIO_PROXIMITY: > + ret = vcnl4040_read_ps_calibbias(data, val, val2); > + if (ret < 0) > + return ret; > + return IIO_VAL_INT_PLUS_MICRO; > + default: > + return -EINVAL; > + }
-- With Best Regards, Andy Shevchenko
| |