Messages in this thread | | | Date | Sun, 28 May 2023 20:03:42 +0100 | From | Jonathan Cameron <> | Subject | Re: [PATCH v4 6/7] iio: light: vcnl4000: Add oversampling_ratio for 4040/4200 |
| |
On Mon, 22 May 2023 16:26:20 +0200 Astrid Rost <astrid.rost@axis.com> wrote:
> Add the proximity multi pulse (PS_MPS) as oversampling_ratio. > Instead of one single pulse per every defined time frame, > one can program 2, 4, or even 8 pulses. This leads to a > longer IRED on-time for each proximity measurement value, which > also results in a higher detection range. > > Add read/write attribute for proximity oversampling-ratio and read > attribute for available oversampling-ratio. > This is supported for vcnl4040 and vcnl4200. > > Signed-off-by: Astrid Rost <astrid.rost@axis.com>
I applied the series and did a build test which showed me...
> @@ -1648,6 +1729,9 @@ static const struct iio_chan_spec vcnl4040_channels[] = { > .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | > BIT(IIO_CHAN_INFO_INT_TIME), > .info_mask_separate_available = BIT(IIO_CHAN_INFO_INT_TIME), > + BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO), > + .info_mask_separate_available = BIT(IIO_CHAN_INFO_INT_TIME) | > + BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO), Guessing a rebase went wrong?
I thought about just fixing this up by dropping the duplication, but given I'm not 100% sure nothing else was affected, I'll leave it to you to fix up and check for any other related issues for a v5.
Jonathan
> .ext_info = vcnl4000_ext_info, > .event_spec = vcnl4040_event_spec, > .num_event_specs = ARRAY_SIZE(vcnl4040_event_spec),
| |