lkml.org 
[lkml]   [2023]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/8] net: netronome: constify pointers to hwmon_channel_info
On Fri, Apr 07, 2023 at 04:59:04PM +0200, Krzysztof Kozlowski wrote:
> Statically allocated array of pointed to hwmon_channel_info can be made
> const for safety.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> This depends on hwmon core patch:
> https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski@linaro.org/
>
> Therefore I propose this should also go via hwmon tree.
>
> Cc: Jean Delvare <jdelvare@suse.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: linux-hwmon@vger.kernel.org

Subject prefix should be 'nfp: '

Other than that, this looks ok to me.
Though I am at a loss as to what tree the patches at the URL above apply to
and thus am unable to verify this code in any way other than visually.

> ---
> drivers/net/ethernet/netronome/nfp/nfp_hwmon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_hwmon.c b/drivers/net/ethernet/netronome/nfp/nfp_hwmon.c
> index 5cabb1aa9c0c..0d6c59d6d4ae 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_hwmon.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_hwmon.c
> @@ -115,7 +115,7 @@ static const struct hwmon_channel_info nfp_power = {
> .config = nfp_power_config,
> };
>
> -static const struct hwmon_channel_info *nfp_hwmon_info[] = {
> +static const struct hwmon_channel_info * const nfp_hwmon_info[] = {
> &nfp_chip,
> &nfp_temp,
> &nfp_power,
> --
> 2.34.1
>

\
 
 \ /
  Last update: 2023-04-07 18:09    [W:0.176 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site