Messages in this thread Patch in this message | | | From | "D. Starke" <> | Subject | [PATCH v2 1/9] tty: n_gsm: fix redundant assignment of gsm->encoding | Date | Thu, 20 Apr 2023 10:50:09 +0200 |
| |
From: Daniel Starke <daniel.starke@siemens.com>
The function gsmld_open() contains a redundant assignment of gsm->encoding. The same value of GSM_ADV_OPT is already assigned to it during the initialization of the struct in gsm_alloc_mux() a few lines earlier.
Fix this by removing the redundant second assignment of gsm->encoding in gsmld_open().
Fixes: e1eaea46bb40 ("tty: n_gsm line discipline") Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Daniel Starke <daniel.starke@siemens.com> --- drivers/tty/n_gsm.c | 1 - 1 file changed, 1 deletion(-)
v1 -> v2: Added Reviewed-by tag.
Link: https://lore.kernel.org/all/adf7aae2-2fd8-b191-f37-75185167f418@linux.intel.com/
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c index b7e1369a035c..c42c8b89fd46 100644 --- a/drivers/tty/n_gsm.c +++ b/drivers/tty/n_gsm.c @@ -3585,7 +3585,6 @@ static int gsmld_open(struct tty_struct *tty) tty->receive_room = 65536; /* Attach the initial passive connection */ - gsm->encoding = GSM_ADV_OPT; gsmld_attach_gsm(tty, gsm); /* The mux will not be activated yet, we wait for correct -- 2.34.1
| |