Messages in this thread | | | Date | Mon, 17 Apr 2023 07:59:34 -0400 | Subject | Re: [PATCH v3 6/7] mm/gup: remove vmas parameter from pin_user_pages() | From | Dennis Dalessandro <> |
| |
On 4/15/23 8:09 AM, Lorenzo Stoakes wrote: > After the introduction of FOLL_SAME_FILE we no longer require vmas for any > invocation of pin_user_pages(), so eliminate this parameter from the > function and all callers. > > This clears the way to removing the vmas parameter from GUP altogether. > > Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com> > --- > arch/powerpc/mm/book3s64/iommu_api.c | 2 +- > drivers/infiniband/hw/qib/qib_user_pages.c | 2 +- > drivers/infiniband/hw/usnic/usnic_uiom.c | 2 +- > drivers/infiniband/sw/siw/siw_mem.c | 2 +- > drivers/media/v4l2-core/videobuf-dma-sg.c | 2 +- > drivers/vdpa/vdpa_user/vduse_dev.c | 2 +- > drivers/vhost/vdpa.c | 2 +- > include/linux/mm.h | 3 +-- > io_uring/rsrc.c | 2 +- > mm/gup.c | 9 +++------ > mm/gup_test.c | 9 ++++----- > net/xdp/xdp_umem.c | 2 +- > 12 files changed, 17 insertions(+), 22 deletions(-) > > diff --git a/drivers/infiniband/hw/qib/qib_user_pages.c b/drivers/infiniband/hw/qib/qib_user_pages.c > index f693bc753b6b..1bb7507325bc 100644 > --- a/drivers/infiniband/hw/qib/qib_user_pages.c > +++ b/drivers/infiniband/hw/qib/qib_user_pages.c > @@ -111,7 +111,7 @@ int qib_get_user_pages(unsigned long start_page, size_t num_pages, > ret = pin_user_pages(start_page + got * PAGE_SIZE, > num_pages - got, > FOLL_LONGTERM | FOLL_WRITE, > - p + got, NULL); > + p + got); > if (ret < 0) { > mmap_read_unlock(current->mm); > goto bail_release;
For Qib...
Acked-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
| |