Messages in this thread | | | Date | Mon, 17 Apr 2023 13:01:18 +0200 | Subject | Re: [PATCH v3 3/7] mm/gup: remove vmas parameter from get_user_pages_remote() | From | David Hildenbrand <> |
| |
On 15.04.23 14:09, Lorenzo Stoakes wrote: > The only instances of get_user_pages_remote() invocations which used the > vmas parameter were for a single page which can instead simply look up the > VMA directly. In particular:- > > - __update_ref_ctr() looked up the VMA but did nothing with it so we simply > remove it. > > - __access_remote_vm() was already using vma_lookup() when the original > lookup failed so by doing the lookup directly this also de-duplicates the > code. > > This forms part of a broader set of patches intended to eliminate the vmas > parameter altogether. > > Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com> > ---
I guess we should never drop the mmap lock temporarily in these cases, so it's fine.
Acked-by: David Hildenbrand <david@redhat.com>
-- Thanks,
David / dhildenb
| |