lkml.org 
[lkml]   [2023]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] gpio: mxs: use dynamic allocation of base
Date
Since commit 502df79b860563d7 ("gpiolib: Warn on drivers still using static
gpiobase allocation"), one or more warnings are printed during boot on
systems where static allocation of GPIO base is used:

[ 0.136834] gpio gpiochip0: Static allocation of GPIO base is deprecated, use dynamic allocation.
[ 0.142753] gpio gpiochip1: Static allocation of GPIO base is deprecated, use dynamic allocation.
[ 0.148452] gpio gpiochip2: Static allocation of GPIO base is deprecated, use dynamic allocation.
[ 0.154341] gpio gpiochip3: Static allocation of GPIO base is deprecated, use dynamic allocation.
[ 0.160097] gpio gpiochip4: Static allocation of GPIO base is deprecated, use dynamic allocation.

So let's follow the suggestion and use dynamic allocation.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---

drivers/gpio/gpio-mxs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-mxs.c b/drivers/gpio/gpio-mxs.c
index 7f59e5d936c2..b48a7c1fb7c1 100644
--- a/drivers/gpio/gpio-mxs.c
+++ b/drivers/gpio/gpio-mxs.c
@@ -330,7 +330,7 @@ static int mxs_gpio_probe(struct platform_device *pdev)

port->gc.to_irq = mxs_gpio_to_irq;
port->gc.get_direction = mxs_gpio_get_direction;
- port->gc.base = port->id * 32;
+ port->gc.base = -1;

err = gpiochip_add_data(&port->gc, port);
if (err)
--
2.32.0
\
 
 \ /
  Last update: 2023-03-27 00:36    [W:0.047 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site