Messages in this thread | | | From | Alistair Francis <> | Date | Sun, 26 Feb 2023 15:52:19 +1000 | Subject | Re: [PATCH v3 3/3] ARM: dts: imx7d-remarkable2: Enable the rohm,bd71815 |
| |
On Sun, Feb 26, 2023 at 6:37 AM Fabio Estevam <festevam@gmail.com> wrote: > > On Sat, Feb 25, 2023 at 8:37 AM Alistair Francis <alistair@alistair23.me> wrote: > > > +&i2c2 { > > + clock-frequency = <100000>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_i2c2>; > > + status = "okay"; > > + > > + bd71815: pmic@4b { > > + compatible = "rohm,bd71815"; > > + reg = <0x4b>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_bd71815>; > > + interrupt-parent = <&gpio6>; /* PMIC_INT_B GPIO6_IO16 */ > > + interrupts = <16 IRQ_TYPE_LEVEL_LOW>; > > + gpio-controller; > > + clocks = <&clks IMX7D_CLKO2_ROOT_SRC>; > > + clock-output-names = "bd71815-32k-out"; > > + #clock-cells = <0>; > > + #gpio-cells = <1>; > > The binding document says #gpio-cells = <2>;
Fixed!
> > > + > > + regulators { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + buck1_reg: regulator@0 { > > + reg = <0>; > > The regulator@0 and reg should not be present.
Fixed
> > Please check Documentation/devicetree/bindings/mfd/rohm,bd71815-pmic.yaml
Thanks, I double checked my latest code against the bindings.
Alistair
| |