Messages in this thread | | | Date | Thu, 23 Feb 2023 10:08:00 +0100 | Subject | Re: [PATCH v1 3/3] arch/arm: dts: introduce meson-a1 device tree | From | Krzysztof Kozlowski <> |
| |
On 22/02/2023 12:50, Alexey Romanov wrote: > Add basic support for the 32-bit Amlogic A1. This device tree
Use subject prefixes matching the subsystem (which you can get for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching).
> describes following compontents: CPU, GIC, IRQ, Timer, UART, > PIN controller. It's capable of booting up into > the serial console. > > This is based on arm64 version of meson-a1.dtsi. > > Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru> > --- > arch/arm/boot/dts/meson-a1.dtsi | 151 ++++++++++++++++++++++++++++++++
There is such file and there is such DTS/hardware support. I don't see any reason why entire DTSI should be duplicated. What's more, your commit does not explain it - does not justify duplication.
Best regards, Krzysztof
| |