lkml.org 
[lkml]   [2023]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 10/11] arm64: dts: qcom: sm8150: fix USB wakeup interrupt types
On Mon, Nov 20, 2023 at 05:43:30PM +0100, Johan Hovold wrote:
> The DP/DM wakeup interrupts are edge triggered and which edge to trigger
> on depends on use-case and whether a Low speed or Full/High speed device
> is connected.
>
> Fixes: 0c9dde0d2015 ("arm64: dts: qcom: sm8150: Add secondary USB and PHY nodes")
> Fixes: b33d2868e8d3 ("arm64: dts: qcom: sm8150: Add USB and PHY device nodes")
> Cc: stable@vger.kernel.org # 5.10
> Cc: Jonathan Marek <jonathan@marek.ca>
> Cc: Jack Pham <quic_jackp@quicinc.com>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---

Reviewed-by: Jack Pham <quic_jackp@quicinc.com>

> arch/arm64/boot/dts/qcom/sm8150.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> index 97623af13464..3e7048d8ac55 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> @@ -3567,8 +3567,8 @@ usb_1: usb@a6f8800 {
>
> interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 486 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 488 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 489 IRQ_TYPE_LEVEL_HIGH>;
> + <GIC_SPI 488 IRQ_TYPE_EDGE_BOTH>,
> + <GIC_SPI 489 IRQ_TYPE_EDGE_BOTH>;
> interrupt-names = "hs_phy_irq", "ss_phy_irq",
> "dm_hs_phy_irq", "dp_hs_phy_irq";
>
> @@ -3620,8 +3620,8 @@ usb_2: usb@a8f8800 {
>
> interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 487 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 490 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 491 IRQ_TYPE_LEVEL_HIGH>;
> + <GIC_SPI 490 IRQ_TYPE_EDGE_BOTH>,
> + <GIC_SPI 491 IRQ_TYPE_EDGE_BOTH>;
> interrupt-names = "hs_phy_irq", "ss_phy_irq",
> "dm_hs_phy_irq", "dp_hs_phy_irq";

\
 
 \ /
  Last update: 2023-11-23 03:17    [W:0.110 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site