Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 20 Nov 2023 18:53:29 +0200 | From | Abel Vesa <> | Subject | Re: [PATCH 11/11] arm64: dts: qcom: sm8550: fix USB wakeup interrupt types |
| |
On 23-11-20 17:43:31, Johan Hovold wrote: > The DP/DM wakeup interrupts are edge triggered and which edge to trigger > on depends on use-case and whether a Low speed or Full/High speed device > is connected. > > Note that only triggering on rising edges can be used to detect resume > events but not disconnect events. > > Fixes: 7f7e5c1b037f ("arm64: dts: qcom: sm8550: Add USB PHYs and controller nodes") > Cc: Abel Vesa <abel.vesa@linaro.org> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
> --- > arch/arm64/boot/dts/qcom/sm8550.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi > index 7b9ddde0b2c9..9b5b098bb7e8 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi > @@ -2923,8 +2923,8 @@ usb_1: usb@a6f8800 { > > interrupts-extended = <&intc GIC_SPI 130 IRQ_TYPE_LEVEL_HIGH>, > <&pdc 17 IRQ_TYPE_LEVEL_HIGH>, > - <&pdc 15 IRQ_TYPE_EDGE_RISING>, > - <&pdc 14 IRQ_TYPE_EDGE_RISING>; > + <&pdc 15 IRQ_TYPE_EDGE_BOTH>, > + <&pdc 14 IRQ_TYPE_EDGE_BOTH>; > interrupt-names = "hs_phy_irq", > "ss_phy_irq", > "dm_hs_phy_irq", > -- > 2.41.0 >
| ![\](/images/icornerr.gif) |