Messages in this thread | | | Date | Mon, 9 Oct 2023 14:20:30 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 4/4] x86/percpu: Use C for percpu read/write accessors |
| |
* Uros Bizjak <ubizjak@gmail.com> wrote:
> On Mon, Oct 9, 2023 at 1:51 PM Ingo Molnar <mingo@kernel.org> wrote: > > > > > > * Ingo Molnar <mingo@kernel.org> wrote: > > > > > > > > * Uros Bizjak <ubizjak@gmail.com> wrote: > > > > > > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > > > > index ecb256954351..1edf4a5b93ca 100644 > > > > --- a/arch/x86/Kconfig > > > > +++ b/arch/x86/Kconfig > > > > @@ -2393,7 +2393,7 @@ config CC_HAS_NAMED_AS > > > > > > > > config USE_X86_SEG_SUPPORT > > > > def_bool y > > > > - depends on CC_HAS_NAMED_AS && SMP > > > > + depends on CC_HAS_NAMED_AS && SMP && !KASAN > > > > + depends on CC_HAS_NAMED_AS && SMP && !KASAN > > > > > > So I'd rather express this as a Kconfig quirk line, and explain each quirk. > > > > > > Something like: > > > > > > depends on CC_HAS_NAMED_AS > > > depends on SMP > > > # > > > # -fsanitize=kernel-address (KASAN) is at the moment incompatible > > > # with named address spaces - see GCC bug #12345. > > > # > > > depends on !KASAN > > > > > > ... or so. > > > > BTW., while this OK for testing, this is too heavy handed for release > > purposes, so please only disable the KASAN instrumentation for the affected > > percpu accessors. > > > > See the various __no_sanitize* attributes available. > > These attributes are for function declarations. The percpu casts can > not be implemented with separate static inline functions. Also, > __no_sanitize_address is mutually exclusive with __always_inline.
Sigh - I guess the Kconfig toggle is the only solution then?
Thanks,
Ingo
| |