Messages in this thread | | | Date | Mon, 9 Oct 2023 19:25:17 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v11 05/10] x86/resctrl: Unwind the errors inside rdt_enable_ctx() |
| |
On Tue, Oct 03, 2023 at 06:54:25PM -0500, Babu Moger wrote: > rdt_enable_ctx() enables the features provided during resctrl mount. > > Additions to rdt_enable_ctx() are required to also modify error paths > of rdt_enable_ctx() callers to ensure correct unwinding if errors > are encountered after calling rdt_enable_ctx(). This is error prone. > > Introduce rdt_disable_ctx() to refactor the error unwinding of > rdt_enable_ctx() to simplify future additions. This also simplifies > cleanup in rdt_kill_sb(). > > Remove cdp_disable_all() as it is not used anymore after the refactor.
Do not talk about *what* the patch is doing in the commit message - that should be obvious from the diff itself. Rather, concentrate on the *why* it needs to be done.
Check your whole series.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |