Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 9 Oct 2023 10:48:38 -0700 | Subject | Re: [PATCH v11 03/10] x86/resctrl: Rename rftype flags for consistency | From | Reinette Chatre <> |
| |
Hi Boris,
On 10/9/2023 10:19 AM, Borislav Petkov wrote: > On Tue, Oct 03, 2023 at 06:54:23PM -0500, Babu Moger wrote: >> resctrl associates rftype flags with its files so that files can be chosen >> based on the resource, whether it is info or base, and if it is control >> or monitor type file. These flags use the RF_ as well as RFTYPE_ prefixes. >> >> Change the prefix to RFTYPE_ for all these flags to be consistent. >> >> Add RFTYPE_MON_BASE that will be used in a later patch. RFTYPE_MON_BASE >> complements existing RFTYPE_CTRL_BASE and represents files >> belonging to monitoring groups. > > First of all, the concept of "later patch" has no meaning when the > patches go into git, depending on the listing order. > > Second, why isn't this define added in the patch that's using it? > > A patch needs to be a logically separate, possibly self-contained > change - remember that.
My apologies here. Babu was following my guidance on this.
Reinette
| ![\](/images/icornerr.gif) |