Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Fri, 27 Jan 2023 09:11:34 +0100 | Subject | Re: [PATCH v2 03/11] soc: renesas: Move away from using OF_POPULATED for fw_devlink |
| |
Hi Saravana,
On Fri, Jan 27, 2023 at 1:11 AM Saravana Kannan <saravanak@google.com> wrote: > The OF_POPULATED flag was set to let fw_devlink know that the device > tree node will not have a struct device created for it. This information > is used by fw_devlink to avoid deferring the probe of consumers of this > device tree node. > > Let's use fwnode_dev_initialized() instead because it achieves the same > effect without using OF specific flags. This allows more generic code to > be written in driver core. > > Signed-off-by: Saravana Kannan <saravanak@google.com>
Thanks for your patch!
> --- a/drivers/soc/renesas/rcar-sysc.c > +++ b/drivers/soc/renesas/rcar-sysc.c > @@ -437,7 +437,7 @@ static int __init rcar_sysc_pd_init(void) > > error = of_genpd_add_provider_onecell(np, &domains->onecell_data); > if (!error) > - of_node_set_flag(np, OF_POPULATED); > + fwnode_dev_initialized(&np->fwnode, true);
As drivers/soc/renesas/rmobile-sysc.c is already using this method, it should work fine.
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-devel for v6.4.
> > out_put: > of_node_put(np);
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |