lkml.org 
[lkml]   [2023]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 04/11] gpiolib: Clear the gpio_device's fwnode initialized flag before adding
On Fri, Jan 27, 2023 at 11:33:38PM -0800, Saravana Kannan wrote:
> On Fri, Jan 27, 2023 at 1:27 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Thu, Jan 26, 2023 at 04:11:31PM -0800, Saravana Kannan wrote:

...

> > > + /*
> > > + * If fwnode doesn't belong to another device, it's safe to clear its
> > > + * initialized flag.
> > > + */
> > > + if (!gdev->dev.fwnode->dev)
> > > + fwnode_dev_initialized(gdev->dev.fwnode, false);
> >
> > Do not dereference fwnode in struct device. Use dev_fwnode() for that.
> >
> > struct fwnode_handle *fwnode = dev_fwnode(&gdev->dev);
> >
> > if (!fwnode->dev)
> > fwnode_dev_initialized(fwnode, false);
>
> Honestly, we should work towards NOT needing dev_fwnode().

Honestly, it's that We SHOULD go to avoid any direct dereference of fwnode from
the struct device. I explained you in the comment in the other patch.

> The
> function literally dereferences dev->fwnode or the one inside of_node.
> So my dereference is fine. The whole "fwnode might not be set for
> devices with of_node" is wrong and we should fix that instead of
> writing wrappers to work around it.
>
> Also, for now I'm going to leave this as if for the same reasons as I
> mentioned in Patch 1.

Same.


--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2023-03-27 00:01    [W:0.085 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site