lkml.org 
[lkml]   [2022]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 05/20] pinctrl/rockchip: of_populate_platform for gpio only for of node
Date
As the of_populate_platform named with prefix "of_", it should be done
only when the of node is exist.

Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
---
drivers/pinctrl/pinctrl-rockchip.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index 8f102f327af8..42aa3552417a 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -3296,12 +3296,11 @@ static int rockchip_pinctrl_probe(struct platform_device *pdev)
void __iomem *base;
int ret;

- if (!is_of_node(fwnode))
- return dev_err_probe(dev, -ENODEV, "device tree node not found\n");
-
- ret = of_platform_populate(np, NULL, NULL, dev);
- if (ret)
- return dev_err_probe(dev, ret, "failed to register gpio device\n");
+ if (is_of_node(fwnode)) {
+ ret = of_platform_populate(np, NULL, NULL, dev);
+ if (ret)
+ return dev_err_probe(dev, ret, "failed to register gpio device\n");
+ }

info = devm_kzalloc(dev, sizeof(*info), GFP_KERNEL);
if (!info)
--
2.25.1
\
 
 \ /
  Last update: 2022-09-20 12:32    [W:0.336 / U:24.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site