Messages in this thread | | | Date | Tue, 4 Oct 2022 11:30:17 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH 11/20] gpio/rockchip: add of_node for gpiochip |
| |
On Tue, Oct 04, 2022 at 09:14:38AM +0200, Linus Walleij wrote: > On Tue, Sep 20, 2022 at 12:31 PM Jianqun Xu <jay.xu@rock-chips.com> wrote: > > The Rockchip GPIO driver will probe before pinctrl and has no parent dt > > node, lack of the of_node will cause the driver probe failure. > > > > Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com> > > > +#ifdef CONFIG_OF_GPIO > > + gc->of_node = of_node_get(bank->dev->of_node); > > +#endif > > Any introduction of of_node_get() needs to be balanced with a > corresponding of_node_put().
No, this code should not have been existed in the first place. We don't allow anymore any of of_node usage in the GPIO drivers. There is an fwnode and parent and logic to retrieve fwnode from parent in the GPIO library for the most of the cases.
-- With Best Regards, Andy Shevchenko
| |