Messages in this thread | | | From | bingjingc <> | Subject | [PATCH 0/2] btrfs: send: fix a bug that sending unlink commands for directories | Date | Mon, 8 Aug 2022 18:27:33 +0800 |
| |
From: BingJing Chang <bingjingc@synology.com>
There is a bug sending unlink commands for directories. In commit 46b2f4590aab ("Btrfs: fix send failure when root has deleted files still open")', orphan inode issue was addressed. There're no reference paths for these orphan inodes, so the send operation fails with an ENOENT error. Therefore, in that patch, sctx->ignore_cur_inode was introduced to be set if the current inode has a link count of zero for bypassing some unnecessary steps. And a helper function btrfs_unlink_all_paths() was introduced and called to clean up old reference paths found in the parent snapshot. However, not only regular files but also directories can be orphan inodes. So if it meets an orphan directory, a wrong unlink command for this directory will be issued. Soon the unlink command fails with an EISDIR error.
BingJing Chang (2): btrfs: send: refactor get_inode_info() btrfs: send: fix a bug that sending unlink commands for directories
fs/btrfs/send.c | 390 +++++++++++++++++++++++------------------------- 1 file changed, 189 insertions(+), 201 deletions(-)
-- 2.37.1
| |