Messages in this thread | | | Subject | [PATCH net 0/5] rxrpc: Miscellaneous fixes | From | David Howells <> | Date | Sat, 21 May 2022 09:02:58 +0100 |
| |
Here are some fixes for AF_RXRPC:
(1) Fix listen() allowing preallocation to overrun the prealloc buffer.
(2) Prevent resending the request if we've seen the reply starting to arrive.
(3) Fix accidental sharing of ACK state between transmission and reception.
(4) Ignore ACKs in which ack.previousPacket regresses. This indicates the highest DATA number so far seen, so should not be seen to go backwards.
(5) Fix the determination of when to generate an IDLE-type ACK, simplifying it so that we generate one if we have more than two DATA packets that aren't hard-acked (consumed) or soft-acked (in the rx buffer, but could be discarded and re-requested).
The patches are tagged here:
git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-fixes-20220521
and can also be found on the following branch:
http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-fixes
Tested-by: kafs-testing+fedora34_64checkkafs-build-495@auristor.com
Changes ======= ver #2) - Rebased onto net/master - Dropped the IPv6 checksum patch as it's already upstream.
David
Link: https://lore.kernel.org/r/165306442115.34086.1818959430525328753.stgit@warthog.procyon.org.uk/ # v1 --- David Howells (5): rxrpc: Fix listen() setting the bar too high for the prealloc rings rxrpc: Don't try to resend the request if we're receiving the reply rxrpc: Fix overlapping ACK accounting rxrpc: Don't let ack.previousPacket regress rxrpc: Fix decision on when to generate an IDLE ACK
include/trace/events/rxrpc.h | 2 +- net/rxrpc/ar-internal.h | 13 +++++++------ net/rxrpc/call_event.c | 3 ++- net/rxrpc/input.c | 31 ++++++++++++++++++++----------- net/rxrpc/output.c | 20 ++++++++++++-------- net/rxrpc/recvmsg.c | 8 +++----- net/rxrpc/sysctl.c | 4 ++-- 7 files changed, 47 insertions(+), 34 deletions(-)
| |