lkml.org 
[lkml]   [2022]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/8] md/raid5: Refactor raid5_make_request loop
On Thu, Apr 07, 2022 at 10:45:04AM -0600, Logan Gunthorpe wrote:
> + spin_lock_irq(&conf->device_lock);
> + if (mddev->reshape_backwards
> + ? logical_sector >= conf->reshape_progress
> + : logical_sector < conf->reshape_progress)

Normal kernel style is to have the operators at the end of the previous
line (and the whole reshape_backwards handlign is ripe for a bunhc
of well contained helpers).

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

\
 
 \ /
  Last update: 2022-04-08 08:01    [W:0.085 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site