Messages in this thread | | | Date | Thu, 7 Apr 2022 23:05:24 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH v1 6/8] md/raid5: Refactor add_stripe_bio() |
| |
On Thu, Apr 07, 2022 at 10:45:09AM -0600, Logan Gunthorpe wrote: > +static int stripe_bio_overlaps(struct stripe_head *sh, struct bio *bi, > + int dd_idx, int forwrite)
This might be a good time to switch the int used as boolean return value to an actual bool.
> + pr_debug("checking bi b#%llu to stripe s#%llu\n", > + (unsigned long long)bi->bi_iter.bi_sector, > + (unsigned long long)sh->sector);
sector_t has always been a u64 for years, so these casts are not needed.
| |