Messages in this thread | | | Date | Mon, 04 Apr 2022 18:03:28 +0200 | From | "Sven Peter" <> | Subject | Re: [PATCH 6/9] nvme-apple: Add initial Apple SoC NVMe driver |
| |
On Mon, Apr 4, 2022, at 17:59, Christoph Hellwig wrote: > On Tue, Apr 05, 2022 at 12:57:33AM +0900, Hector Martin wrote: >> The kernel hard limit is 100-character lines, not 80-character lines. >> Maintainers for existing drivers are certainly free to stick to 80 chars >> if they like it that way, but I don't see why we should still be >> enforcing that for new code. See bdc48fa11e46. > > Because 100 is completely utterly unreadable if is not for individual > lines like strings, and that is actually how Linus stated it in CodingStyle. > > Your code as-is is completely unreadable and will not go into > drivers/nvme/ in that form.
fwiw, I wrote that code and I just forgot to check the line length after some last minute changes again. It's already been reduced to 80 chars in my local tree.
Sven
| |