Messages in this thread | | | Date | Mon, 4 Apr 2022 12:29:08 -0600 | Subject | Re: [PATCH 6/9] nvme-apple: Add initial Apple SoC NVMe driver | From | Jens Axboe <> |
| |
On 4/4/22 9:59 AM, Christoph Hellwig wrote: > On Tue, Apr 05, 2022 at 12:57:33AM +0900, Hector Martin wrote: >> The kernel hard limit is 100-character lines, not 80-character lines. >> Maintainers for existing drivers are certainly free to stick to 80 chars >> if they like it that way, but I don't see why we should still be >> enforcing that for new code. See bdc48fa11e46. > > Because 100 is completely utterly unreadable if is not for individual > lines like strings, and that is actually how Linus stated it in > CodingStyle. > > Your code as-is is completely unreadable and will not go into > drivers/nvme/ in that form.
Please reconsider how you phrase these objections. Saying the code is "completely unreadable" because it's _1_ character over your hard limit is just nonsense, and not a very productive way to deal with this.
-- Jens Axboe
| |