lkml.org 
[lkml]   [2022]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] coccinelle: api/stream_open: Introduce metavariables for checks
Date
Coccinelle spatch version 1.1.1 reports the following:
warning: line 134: should no_llseek be a metavariable?
warning: line 141: should noop_llseek be a metavariable?
warning: line 223: should nonseekable_open be a metavariable?
warning: line 290: should nonseekable_open be a metavariable?
warning: line 338: should nonseekable_open be a metavariable?

So, introduce the metavariable similar to other check instances.

Signed-off-by: Nishanth Menon <nm@ti.com>
---

NOTE: This is currently reported in next-20220404, though I have'nt
bisected for exact fixes tags to be used.

scripts/coccinelle/api/stream_open.cocci | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/scripts/coccinelle/api/stream_open.cocci b/scripts/coccinelle/api/stream_open.cocci
index df00d6619b06..d33732f35710 100644
--- a/scripts/coccinelle/api/stream_open.cocci
+++ b/scripts/coccinelle/api/stream_open.cocci
@@ -129,6 +129,7 @@ identifier llseek_f;

@ has_no_llseek @
identifier fops0.fops;
+identifier no_llseek;
@@
struct file_operations fops = {
.llseek = no_llseek,
@@ -136,6 +137,7 @@ identifier fops0.fops;

@ has_noop_llseek @
identifier fops0.fops;
+identifier noop_llseek;
@@
struct file_operations fops = {
.llseek = noop_llseek,
@@ -216,6 +218,7 @@ identifier stream_writer.writestream;

@ report_rw depends on report @
identifier fops_rw.openfunc;
+identifier nonseekable_open;
position p1;
@@
openfunc(...) {
@@ -283,6 +286,7 @@ identifier stream_reader.readstream;

@ report_r depends on report @
identifier fops_r.openfunc;
+identifier nonseekable_open;
position p1;
@@
openfunc(...) {
@@ -331,6 +335,7 @@ identifier stream_writer.writestream;

@ report_w depends on report @
identifier fops_w.openfunc;
+identifier nonseekable_open;
position p1;
@@
openfunc(...) {
--
2.31.1
\
 
 \ /
  Last update: 2022-04-05 00:46    [W:0.070 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site