lkml.org 
[lkml]   [2022]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v8 4/7] dax: introduce DAX_RECOVERY_WRITE dax access mode
Date
On 4/20/2022 11:57 PM, Christoph Hellwig wrote:
>> + if (bb->count &&
>> + badblocks_check(bb, sector, num, &first_bad, &num_bad)) {
>
> Weird alignment here, continuing lines for conditionals are aligned
> either after the opening brace:
>
> if (bb->count &&
> badblocks_check(bb, sector, num, &first_bad, &num_bad)) {
>
> or with double tabs. I tend to prefer the version I posted above.
>
> The being said, shouldn't this change even be in this patch and not just
> added once we add actual recovery support?

Right, will move the recovery_write related changes to next patch.

thanks!
-jane

\
 
 \ /
  Last update: 2022-04-22 06:16    [W:0.044 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site