lkml.org 
[lkml]   [2022]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v8 4/7] dax: introduce DAX_RECOVERY_WRITE dax access mode
> +	if (bb->count &&
> + badblocks_check(bb, sector, num, &first_bad, &num_bad)) {

Weird alignment here, continuing lines for conditionals are aligned
either after the opening brace:

if (bb->count &&
badblocks_check(bb, sector, num, &first_bad, &num_bad)) {

or with double tabs. I tend to prefer the version I posted above.

The being said, shouldn't this change even be in this patch and not just
added once we add actual recovery support?

\
 
 \ /
  Last update: 2022-04-21 08:59    [W:0.359 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site