| Date | Thu, 3 Mar 2022 12:30:10 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v3 03/11] i2c: npcm: Fix client address calculation |
| |
On Thu, Mar 03, 2022 at 04:31:33PM +0800, Tyrone Ting wrote: > From: Tali Perry <tali.perry1@gmail.com> > > Fix i2c client address by left-shifting 1 bit before > applying it to the data register.
...
> - bus->dest_addr = slave_addr; > + bus->dest_addr = slave_addr << 1;
1. Why this is not using i2c_8bit_addr_from_msg() helper? 2. This is duplication of what npcm_i2c_master_start_xmit() does.
Taking 2 into account, what is this exactly fixing? Sounds like a red herring.
-- With Best Regards, Andy Shevchenko
|