lkml.org 
[lkml]   [2022]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v3 03/11] i2c: npcm: Fix client address calculation
    Hi Andy:

    Thank you for your comment and it'll be addressed.

    Andy Shevchenko <andriy.shevchenko@linux.intel.com> 於 2022年3月3日 週四 下午6:31寫道:
    >
    > On Thu, Mar 03, 2022 at 04:31:33PM +0800, Tyrone Ting wrote:
    > > From: Tali Perry <tali.perry1@gmail.com>
    > >
    > > Fix i2c client address by left-shifting 1 bit before
    > > applying it to the data register.
    >
    > ...
    >
    > > - bus->dest_addr = slave_addr;
    > > + bus->dest_addr = slave_addr << 1;
    >
    > 1. Why this is not using i2c_8bit_addr_from_msg() helper?
    > 2. This is duplication of what npcm_i2c_master_start_xmit() does.
    >
    > Taking 2 into account, what is this exactly fixing?
    > Sounds like a red herring.
    >
    > --
    > With Best Regards,
    > Andy Shevchenko
    >
    >

    Best regards,
    Tyrone

    \
     
     \ /
      Last update: 2022-03-04 14:39    [W:4.068 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site