lkml.org 
[lkml]   [2022]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v1 3/3] auxdisplay: lcd2s: Use proper API to free the instance of charlcd object
On Wed, Feb 23, 2022 at 4:47 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> While it might work, the current approach is fragile in a few ways:
> - whenever members in the structure are shuffled, the pointer will be wrong
> - the resource freeing may include more than covered by kfree()
>
> Fix this by using charlcd_free() call instead of kfree().
>
> Fixes: 8c9108d014c5 ("auxdisplay: add a driver for lcd2s character display")
> Cc: Lars Poeschel <poeschel@lemonage.de>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thanks Andy, queued.

Cheers,
Miguel

\
 
 \ /
  Last update: 2022-03-03 02:22    [W:0.074 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site