Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Wed, 2 Mar 2022 17:12:10 +0100 | Subject | Re: [PATCH v1 1/3] auxdisplay: lcd2s: Fix lcd2s_redefine_char() feature |
| |
On Thu, Feb 24, 2022 at 2:03 AM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > It seems that the lcd2s_redefine_char() has never been properly > tested. The buffer is filled by DEF_CUSTOM_CHAR command followed > by the character number (from 0 to 7), but immediately after that > these bytes are got rewritten by the decoded hex stream. > > Fix the index to fill the buffer after the command and number. > > Fixes: 8c9108d014c5 ("auxdisplay: add a driver for lcd2s character display") > Cc: Lars Poeschel <poeschel@lemonage.de> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |