Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 7 Feb 2022 17:09:37 +0100 | Subject | Re: [PATCH 3/6] dt-bindings: watchdog: renesas,wdt: Add support for RZ/N1 |
| |
Hi Jean-Jacques,
On Fri, Feb 4, 2022 at 5:18 PM Jean-Jacques Hiblot <jjhiblot@traphandler.com> wrote: > Describe the WDT hardware in the RZ/N1 series. > > Signed-off-by: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
Thanks for your patch!
> --- a/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml > +++ b/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml > @@ -19,6 +19,9 @@ properties: > - renesas,r7s9210-wdt # RZ/A2 > - const: renesas,rza-wdt # RZ/A > > + - items: > + - const: renesas,rzn1-wdt # RZ/N1
I think it would be good to have an SoC-specific compatible value ("renesas,r9a06g032-wdt") in addition to the family-specific one.
> + > - items: > - enum: > - renesas,r9a07g044-wdt # RZ/G2{L,LC}
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |