lkml.org 
[lkml]   [2022]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf stat: Fix display of grouped aliased events.
Em Fri, Feb 04, 2022 at 05:48:20PM -0800, Andi Kleen escreveu:
>
> On 2/4/2022 5:09 PM, Ian Rogers wrote:
> > An event may have a number of uncore aliases that when added to
> > the evlist are consecutive. If there are multiple uncore events
> > in a group then parse_events__set_leader_for_uncore_aliase will
> > reorder the evlist so that events on the same PMU are
> > adjacent. collect_all_aliases assumes that aliases are in blocks
> > so that only the first counter is printed and all others are
> > marked merged. The reordering for groups breaks the assumption
> > and so all counts are printed. This change removes the assumption
> > from collect_all_aliases that the events are in blocks and
> > instead processes the entire evlist.
>
> Looks good to me.
>
> Reviewed-by: Andi Kleen <ak@linux.intel.com>

Thanks, applied.

- Arnaldo

\
 
 \ /
  Last update: 2022-02-06 12:57    [W:0.028 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site