Messages in this thread | ![/](/images/icornerl.gif) | | Date | Sun, 6 Feb 2022 08:55:17 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] perf stat: Fix display of grouped aliased events. |
| |
Em Fri, Feb 04, 2022 at 05:48:20PM -0800, Andi Kleen escreveu: > > On 2/4/2022 5:09 PM, Ian Rogers wrote: > > An event may have a number of uncore aliases that when added to > > the evlist are consecutive. If there are multiple uncore events > > in a group then parse_events__set_leader_for_uncore_aliase will > > reorder the evlist so that events on the same PMU are > > adjacent. collect_all_aliases assumes that aliases are in blocks > > so that only the first counter is printed and all others are > > marked merged. The reordering for groups breaks the assumption > > and so all counts are printed. This change removes the assumption > > from collect_all_aliases that the events are in blocks and > > instead processes the entire evlist. > > Looks good to me. > > Reviewed-by: Andi Kleen <ak@linux.intel.com>
Thanks, applied.
- Arnaldo
| ![\](/images/icornerr.gif) |