Messages in this thread | | | Date | Fri, 4 Feb 2022 17:48:20 -0800 | Subject | Re: [PATCH] perf stat: Fix display of grouped aliased events. | From | Andi Kleen <> |
| |
On 2/4/2022 5:09 PM, Ian Rogers wrote: > An event may have a number of uncore aliases that when added to > the evlist are consecutive. If there are multiple uncore events > in a group then parse_events__set_leader_for_uncore_aliase will > reorder the evlist so that events on the same PMU are > adjacent. collect_all_aliases assumes that aliases are in blocks > so that only the first counter is printed and all others are > marked merged. The reordering for groups breaks the assumption > and so all counts are printed. This change removes the assumption > from collect_all_aliases that the events are in blocks and > instead processes the entire evlist.
Looks good to me.
Reviewed-by: Andi Kleen <ak@linux.intel.com>
-Andi
| |