Messages in this thread Patch in this message | | | From | Hangyu Hua <> | Subject | [PATCH] can: usb: fix a possible memory leak in esd_usb2_start_xmit | Date | Fri, 25 Feb 2022 14:00:19 +0800 |
| |
As in case of ems_usb_start_xmit, dev_kfree_skb needs to be called when usb_submit_urb fails to avoid possible refcount leaks.
Signed-off-by: Hangyu Hua <hbh25y@gmail.com> --- drivers/net/can/usb/esd_usb2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/usb/esd_usb2.c b/drivers/net/can/usb/esd_usb2.c index 286daaaea0b8..7b5e6c250d00 100644 --- a/drivers/net/can/usb/esd_usb2.c +++ b/drivers/net/can/usb/esd_usb2.c @@ -810,7 +810,7 @@ static netdev_tx_t esd_usb2_start_xmit(struct sk_buff *skb, usb_unanchor_urb(urb); stats->tx_dropped++; - + dev_kfree_skb(skb); if (err == -ENODEV) netif_device_detach(netdev); else -- 2.25.1
| |