lkml.org 
[lkml]   [2022]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject[ammarfaizi2-block:google/android/kernel/common/android13-5.10 1001/9999] drivers/usb/gadget/configfs.c:1620:9: error: implicit declaration of function 'acc_disconnect'
Hi Ronak,

FYI, the error/warning still remains.

tree: https://github.com/ammarfaizi2/linux-block google/android/kernel/common/android13-5.10
head: 2b5b0c26e9234f1d328d9fe3d2da998d996db1ec
commit: 80fef39de7e9dbe706d0cbc820a09b5c05dc366f [1001/9999] ANDROID: usb: gadget: Resolve NULL pointer dereference in composite_disconnect
config: nios2-randconfig-r032-20220224 (https://download.01.org/0day-ci/archive/20220224/202202241230.Gv0at8F7-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/ammarfaizi2/linux-block/commit/80fef39de7e9dbe706d0cbc820a09b5c05dc366f
git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
git fetch --no-tags ammarfaizi2-block google/android/kernel/common/android13-5.10
git checkout 80fef39de7e9dbe706d0cbc820a09b5c05dc366f
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nios2 SHELL=/bin/bash drivers/usb/gadget/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

drivers/usb/gadget/configfs.c: In function 'configfs_composite_disconnect':
>> drivers/usb/gadget/configfs.c:1620:9: error: implicit declaration of function 'acc_disconnect' [-Werror=implicit-function-declaration]
1620 | acc_disconnect();
| ^~~~~~~~~~~~~~
cc1: some warnings being treated as errors

Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for ASYNC_TX_ENABLE_CHANNEL_SWITCH
Depends on DMADEVICES
Selected by
- GKI_HIDDEN_DMA_CONFIGS


vim +/acc_disconnect +1620 drivers/usb/gadget/configfs.c

1603
1604 static void configfs_composite_disconnect(struct usb_gadget *gadget)
1605 {
1606 struct usb_composite_dev *cdev;
1607 struct gadget_info *gi;
1608 unsigned long flags;
1609
1610 cdev = get_gadget_data(gadget);
1611 if (!cdev)
1612 return;
1613
1614 #ifdef CONFIG_USB_CONFIGFS_F_ACC
1615 /*
1616 * accessory HID support can be active while the
1617 * accessory function is not actually enabled,
1618 * so we need to inform it when we are disconnected.
1619 */
> 1620 acc_disconnect();
1621 #endif
1622 gi = container_of(cdev, struct gadget_info, cdev);
1623 spin_lock_irqsave(&gi->spinlock, flags);
1624 cdev = get_gadget_data(gadget);
1625 if (!cdev || gi->unbind) {
1626 spin_unlock_irqrestore(&gi->spinlock, flags);
1627 return;
1628 }
1629

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

\
 
 \ /
  Last update: 2022-02-24 05:56    [W:0.034 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site