lkml.org 
[lkml]   [2022]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v12 4/6] remoteproc: pru: Make sysfs entries read-only for PRU client driven boots
    Date
    From: Suman Anna <s-anna@ti.com>

    The PRU remoteproc driver is not configured for 'auto-boot' by default,
    and allows to be booted either by in-kernel PRU client drivers or by
    userspace using the generic remoteproc sysfs interfaces. The sysfs
    interfaces should not be permitted to change the remoteproc firmwares
    or states when a PRU is being managed by an in-kernel client driver.
    Use the newly introduced remoteproc generic 'sysfs_read_only' flag to
    provide these restrictions by setting and clearing it appropriately
    during the PRU acquire and release steps.

    Signed-off-by: Suman Anna <s-anna@ti.com>
    Signed-off-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>
    Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
    Reviewed-by: Roger Quadros <rogerq@kernel.org>
    ---
    drivers/remoteproc/pru_rproc.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c
    index fe4ca1584e91..8e2fbe392ef3 100644
    --- a/drivers/remoteproc/pru_rproc.c
    +++ b/drivers/remoteproc/pru_rproc.c
    @@ -223,6 +223,7 @@ struct rproc *pru_rproc_get(struct device_node *np, int index,
    }

    pru->client_np = np;
    + rproc->sysfs_read_only = true;

    mutex_unlock(&pru->lock);

    @@ -261,6 +262,7 @@ void pru_rproc_put(struct rproc *rproc)
    }

    pru->client_np = NULL;
    + rproc->sysfs_read_only = false;
    mutex_unlock(&pru->lock);

    rproc_put(rproc);
    --
    2.25.1
    \
     
     \ /
      Last update: 2022-12-16 06:34    [W:3.250 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site