Messages in this thread |  | | Date | Wed, 14 Dec 2022 13:42:22 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH 1/1] i2c: designware: add pinctrl for recovery info as an option |
| |
On Wed, Dec 14, 2022 at 10:27:07AM +0000, Hanna Hawa wrote: > The current implementation of designware recovery mechanism fit for > specific device (Intel / Altera Cyclone V SOC) which have two separated > "wired" GPIOs to the i2c bus via the SOC FPGA for the i2c recovery. > > This change add ability to get the pinctrl for the i2c recovery in order > to switch between pin configuration (I2C and GPIO functionality) if the > pinctrl exists.
...
> + rinfo->pinctrl = devm_pinctrl_get(dev->dev); > + if (IS_ERR(rinfo->pinctrl)) { > + if (PTR_ERR(rinfo->pinctrl) == -EPROBE_DEFER) > + return -EPROBE_DEFER; > + rinfo->pinctrl = NULL; > + dev_dbg(dev->dev, "can't get pinctrl for i2c recovery\n"); > + }
Can you explain, why pinctrl_bind_pins() is not enough?
(You may also refer to the ab78029ecc34 ("drivers/pinctrl: grab default handles from device core") for more details.)
-- With Best Regards, Andy Shevchenko
|  |