lkml.org 
[lkml]   [2022]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v3] USB: FHCI: fix error return code in of_fhci_probe()
Date
Fix to return a negative error code of PTR_ERR(fhci->gpiods[i])
instead of 0.

Fixes: a4efdb8a423b ("USB: FHCI: Switch to GPIO descriptors")
Signed-off-by: Wang Yufen <wangyufen@huawei.com>
---
drivers/usb/host/fhci-hcd.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/host/fhci-hcd.c b/drivers/usb/host/fhci-hcd.c
index 95a4446..c8a1b98 100644
--- a/drivers/usb/host/fhci-hcd.c
+++ b/drivers/usb/host/fhci-hcd.c
@@ -639,8 +639,9 @@ static int of_fhci_probe(struct platform_device *ofdev)
NULL, i, GPIOD_OUT_LOW);

if (IS_ERR(fhci->gpiods[i])) {
- dev_err(dev, "incorrect GPIO%d: %ld\n",
- i, PTR_ERR(fhci->gpiods[i]));
+ ret = PTR_ERR(fhci->gpiods[i]);
+ dev_err(dev, "incorrect GPIO%d: %d\n",
+ i, ret);
goto err_gpios;
}
if (!fhci->gpiods[i]) {
--
1.8.3.1
\
 
 \ /
  Last update: 2022-11-29 07:24    [W:0.101 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site