lkml.org 
[lkml]   [2022]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] kernel/sched: Update schedstats when migrating threads
Date
The kernel manages per-task scheduler statistics or schedstats. Such
counters should be reinitialized when the thread is migrated to a
different core rq, except for the values recording number of migrations.

Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>
---
kernel/sched/core.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index fe53e510e711..d64c2a290176 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -8757,6 +8757,7 @@ bool sched_smp_initialized __read_mostly;
int migrate_task_to(struct task_struct *p, int target_cpu)
{
struct migration_arg arg = { p, target_cpu };
+ uint64_t forced_migrations, migrations_cold;
int curr_cpu = task_cpu(p);

if (curr_cpu == target_cpu)
@@ -8765,7 +8766,14 @@ int migrate_task_to(struct task_struct *p, int target_cpu)
if (!cpumask_test_cpu(target_cpu, p->cpus_ptr))
return -EINVAL;

- /* TODO: This is not properly updating schedstats */
+ if (schedstat_enabled()) {
+ forced_migrations = schedstat_val(p->stats.nr_forced_migrations);
+ migrations_cold = schedstat_val(p->stats.nr_migrations_cold);
+ memset(&p->stats, 0, sizeof(p->stats));
+ schedstat_set(p->stats.nr_forced_migrations, forced_migrations);
+ schedstat_set(p->stats.nr_migrations_cold, migrations_cold);
+ schedstat_inc(p->stats.nr_migrations_cold);
+ }

trace_sched_move_numa(p, curr_cpu, target_cpu);
return stop_one_cpu(curr_cpu, migration_cpu_stop, &arg);
--
2.27.0
\
 
 \ /
  Last update: 2022-01-26 16:24    [W:0.507 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site