| Subject | [PATCH 05/12] swiotlb-xen: suppress certain init retries | From | Jan Beulich <> | Date | Tue, 7 Sep 2021 14:05:54 +0200 |
| |
Only on the 2nd of the paths leading to xen_swiotlb_init()'s "error" label it is useful to retry the allocation; the first one did already iterate through all possible order values.
Signed-off-by: Jan Beulich <jbeulich@suse.com> --- I'm not convinced of the (lack of) indentation of the label, but I made the new one matzch the existing one.
--- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -184,7 +184,7 @@ retry: order--; } if (!start) - goto error; + goto exit; if (order != get_order(bytes)) { pr_warn("Warning: only able to allocate %ld MB for software IO TLB\n", (PAGE_SIZE << order) >> 20); @@ -214,6 +214,7 @@ error: pr_info("Lowering to %luMB\n", bytes >> 20); goto retry; } +exit: pr_err("%s (rc:%d)\n", xen_swiotlb_error(m_ret), rc); return rc; }
|