| Date | Fri, 10 Sep 2021 15:55:06 -0700 (PDT) | From | Stefano Stabellini <> | Subject | Re: [PATCH 01/12] swiotlb-xen: avoid double free |
| |
On Tue, 7 Sep 2021, Jan Beulich wrote: > Of the two paths leading to the "error" label in xen_swiotlb_init() one > didn't allocate anything, while the other did already free what was > allocated. > > Fixes: b82776005369 ("xen/swiotlb: Use the swiotlb_late_init_with_tbl to init Xen-SWIOTLB late when PV PCI is used") > Signed-off-by: Jan Beulich <jbeulich@suse.com> > Cc: stable@vger.kernel.org
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> --- a/drivers/xen/swiotlb-xen.c > +++ b/drivers/xen/swiotlb-xen.c > @@ -216,7 +216,6 @@ error: > goto retry; > } > pr_err("%s (rc:%d)\n", xen_swiotlb_error(m_ret), rc); > - free_pages((unsigned long)start, order); > return rc; > } > >
|