lkml.org 
[lkml]   [2021]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 1/3] staging: vt6655: fix camelcase in bShortSlotTime
On Tue, Sep 28, 2021 at 06:43:00AM +0200, Greg Kroah-Hartman wrote:
> On Mon, Sep 27, 2021 at 11:35:15PM +0200, Tommaso Merciai wrote:
> > On Mon, Sep 27, 2021 at 05:26:14PM +0200, Greg Kroah-Hartman wrote:
> > > On Sun, Sep 26, 2021 at 06:25:18PM +0200, Tommaso Merciai wrote:
> > > > Replace camel case variable bShortSlotTime with snake case
> > > > variable b_short_slot_time.
> > >
> > > That is a very odd variable name. Why did you pick that one?
> > >
> > > What deos it mean?
> > >
> > > You do understand where the original naming format came from here, and
> > > what it was trying to represent, right? If not, please go read up on
> > > it:
> > > https://en.wikipedia.org/wiki/Hungarian_notation
> > >
> > > That style is not used in Linux, and so, when converting from it, do not
> > > attempt to keep the same style present here, that is kind of pointless,
> > > don't you agree?
> >
> > You are definitely right. What do you think about "short_slot_time"?
>
> "time" implies that this will hold a value of time, right?
>
> What exactly does this variable do? That might help in naming it
> better.

Is a boolean variable, if true short slot time mode is enabled, false
not right?
A good solution could be: "short_slot_mode"? What do you think about?

thanks,
tommaso

>
> thanks,
>
> greg k-h

\
 
 \ /
  Last update: 2021-09-30 23:50    [W:0.067 / U:0.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site