Messages in this thread | | | Date | Mon, 27 Sep 2021 23:35:15 +0200 | From | Tommaso Merciai <> | Subject | Re: [PATCH v5 1/3] staging: vt6655: fix camelcase in bShortSlotTime |
| |
On Mon, Sep 27, 2021 at 05:26:14PM +0200, Greg Kroah-Hartman wrote: > On Sun, Sep 26, 2021 at 06:25:18PM +0200, Tommaso Merciai wrote: > > Replace camel case variable bShortSlotTime with snake case > > variable b_short_slot_time. > > That is a very odd variable name. Why did you pick that one? > > What deos it mean? > > You do understand where the original naming format came from here, and > what it was trying to represent, right? If not, please go read up on > it: > https://en.wikipedia.org/wiki/Hungarian_notation > > That style is not used in Linux, and so, when converting from it, do not > attempt to keep the same style present here, that is kind of pointless, > don't you agree?
You are definitely right. What do you think about "short_slot_time"?
Thanks,
Tommaso > > thanks, > > greg k-h
| |