Messages in this thread | | | From | Chen-Yu Tsai <> | Date | Wed, 1 Sep 2021 21:54:52 +0800 | Subject | Re: [PATCH 5/8] clk: sunxi-ng: Export symbols used by CCU drivers |
| |
On Wed, Sep 1, 2021 at 1:05 PM Samuel Holland <samuel@sholland.org> wrote: > > For the individual drivers to be built as modules, the ops structs and > callback registration functions must be exported. None of the helper > functions are exported, because they are only referenced from the > corresponding ops structs. of_sunxi_ccu_probe is not exported, because > it is only used for built-in early OF clock providers. > > Signed-off-by: Samuel Holland <samuel@sholland.org> > --- > drivers/clk/sunxi-ng/ccu_common.c | 2 ++ > drivers/clk/sunxi-ng/ccu_div.c | 1 + > drivers/clk/sunxi-ng/ccu_gate.c | 1 + > drivers/clk/sunxi-ng/ccu_mp.c | 2 ++ > drivers/clk/sunxi-ng/ccu_mult.c | 1 + > drivers/clk/sunxi-ng/ccu_mux.c | 2 ++ > drivers/clk/sunxi-ng/ccu_nk.c | 1 + > drivers/clk/sunxi-ng/ccu_nkm.c | 1 + > drivers/clk/sunxi-ng/ccu_nkmp.c | 1 + > drivers/clk/sunxi-ng/ccu_nm.c | 1 + > drivers/clk/sunxi-ng/ccu_phase.c | 1 + > drivers/clk/sunxi-ng/ccu_reset.c | 1 + > 12 files changed, 15 insertions(+) > > diff --git a/drivers/clk/sunxi-ng/ccu_common.c b/drivers/clk/sunxi-ng/ccu_common.c > index 31af8b6b5286..3ab109582646 100644 > --- a/drivers/clk/sunxi-ng/ccu_common.c > +++ b/drivers/clk/sunxi-ng/ccu_common.c > @@ -83,6 +83,7 @@ int ccu_pll_notifier_register(struct ccu_pll_nb *pll_nb) > return clk_notifier_register(pll_nb->common->hw.clk, > &pll_nb->clk_nb); > } > +EXPORT_SYMBOL_GPL(ccu_pll_notifier_register);
These symbol names aren't exactly specific to sunxi. Maybe we could apply symbol namespaces?
ChenYu
| |