Messages in this thread | | | From | Stephen Boyd <> | Date | Mon, 23 Aug 2021 18:50:04 -0500 | Subject | Re: [PATCH] thermal: qcom: spmi-adc-tm5: Don't abort probing if a sensor is not used |
| |
Quoting Matthias Kaehlcke (2021-08-23 13:47:30) > adc_tm5_register_tzd() registers the thermal zone sensors for all > channels of the thermal monitor. If the registration of one channel > fails the function skips the processing of the remaining channels > and returns an error, which results in _probe() being aborted. > > One of the reasons the registration could fail is that none of the > thermal zones is using the channel/sensor, which hardly is a critical > error (if it is an error at all). If this case is detected emit a > warning and continue with processing the remaining channels. > > Fixes: ca66dca5eda6 ("thermal: qcom: add support for adc-tm5 PMIC thermal monitor") > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > ---
Reported-by: Stephen Boyd <swboyd@chromium.org> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Should we also disable the 'charger-thermistor@0' node in sc7180-trogdor.dtsi on lazor boards, instead of the thermal zone, or in addition to the thermal zone? It isn't used so there's not much value in exposing it.
| |