Messages in this thread | | | From | "Keller, Jacob E" <> | Subject | RE: [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK dependencies | Date | Mon, 2 Aug 2021 21:09:19 +0000 |
| |
> -----Original Message----- > From: Arnd Bergmann <arnd@kernel.org> > Sent: Monday, August 02, 2021 1:59 PM > To: Keller, Jacob E <jacob.e.keller@intel.com> > Cc: Richard Cochran <richardcochran@gmail.com>; Nicolas Pitre > <nicolas.pitre@linaro.org>; Brandeburg, Jesse <jesse.brandeburg@intel.com>; > Nguyen, Anthony L <anthony.l.nguyen@intel.com>; David S. Miller > <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; Arnd Bergmann > <arnd@arndb.de>; Kurt Kanzenbach <kurt@linutronix.de>; Saleem, Shiraz > <shiraz.saleem@intel.com>; Ertman, David M <david.m.ertman@intel.com>; > intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: Re: [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK > dependencies > > I don't want to mess with the semantics of the keyword any further. > The original meaning was meant to avoid circular dependencies > by making it a softer version of 'select' that would not try to select > anything that has unmet dependencies. The current version made > it even softer by only having an effect during 'make defconfig' > and 'make oldconfig' but not preventing it from being soft-disabled > any more. Changing it yet again is guarantee to break lots of the > existing users, while probably also bringing back the original problem > of the circular dependencies. > > Arnd
Yea ok that makes sense. Better to use a new keyword if we do at all.
| |