lkml.org 
[lkml]   [2021]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK dependencies
On Mon, 2 Aug 2021, Arnd Bergmann wrote:

> On Mon, Aug 2, 2021 at 10:46 PM Keller, Jacob E
> <jacob.e.keller@intel.com> wrote:
>
> > > You can do something like it for a particular symbol though, such as
> > >
> > > config MAY_USE_PTP_1588_CLOCK
> > > def_tristate PTP_1588_CLOCK || !PTP_1588_CLOCK
> > >
> > > config E1000E
> > > tristate "Intel(R) PRO/1000 PCI-Express Gigabit Ethernet support"
> > > depends on PCI && (!SPARC32 || BROKEN)
> > > + depends on MAY_USE_PTP_1588_CLOCK
> > > select CRC32
> > > - imply PTP_1588_CLOCK
> >
> > What about "integrates"?
>
> Maybe, we'd need to look at whether that fits for the other users of the
> "A || !A" trick.

I implemented "conditional dependencies" at the time, which is syntactic
sugar to express the above as:

depends on A if A != n

depends on A if A

etc.

http://lkml.iu.edu/hypermail/linux/kernel/2004.2/09783.html

But Masahiro shut it down.


Nicolas

\
 
 \ /
  Last update: 2021-08-02 23:22    [W:0.518 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site